Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #2189 - add graph --compact support #2305

Merged
merged 7 commits into from
Nov 1, 2022
Merged

fix #2189 - add graph --compact support #2305

merged 7 commits into from
Nov 1, 2022

Conversation

leibale
Copy link
Collaborator

@leibale leibale commented Oct 26, 2022 •
edited
Loading

fix #2189 fix #2191

@lgtm-com
Copy link

lgtm-com bot commented Oct 26, 2022

This pull request introduces 2 alerts when merging e24972d into 4cfad3d - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class
  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link

lgtm-com bot commented Oct 26, 2022

This pull request introduces 1 alert when merging b0f43c5 into 29f734f - view on LGTM.com

new alerts:

  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link

lgtm-com bot commented Oct 26, 2022

This pull request introduces 1 alert when merging 035a01e into 0abd950 - view on LGTM.com

new alerts:

  • 1 for Incomplete string escaping or encoding

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022 •
edited
Loading

Codecov Report

Base: 95.85% // Head: 95.79% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (ab1dc91) compared to base (0abd950).
Patch coverage: 93.69% of modified lines in pull request are covered.

❗ Current head ab1dc91 differs from pull request most recent head 5ecc1d6. Consider uploading reports for the commit 5ecc1d6 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2305      +/-   ##
==========================================
- Coverage   95.85%   95.79%   -0.07%     
==========================================
  Files         433      434       +1     
  Lines        4002     4087      +85     
  Branches      451      462      +11     
==========================================
+ Hits         3836     3915      +79     
- Misses        102      106       +4     
- Partials       64       66       +2
Impacted Files Coverage Δ
packages/client/lib/client/socket.ts 78.57% <84.00%> (-1.43%) ⬇️
packages/graph/lib/graph.ts 96.29% <96.29%> (ø)
packages/client/lib/client/index.ts 91.06% <100.00%> (-0.36%) ⬇️
packages/graph/lib/commands/QUERY.ts 100.00% <100.00%> (ø)
packages/graph/lib/commands/RO_QUERY.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leibale leibale merged commit 1c6d74f into redis:master Nov 1, 2022
@leibale leibale deleted the 2189-graph branch November 1, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GnaneshKunal GnaneshKunal GnaneshKunal approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Require documentation for graph functionality. Features available in redisgraph.js is not in @redis/graph
3 participants
@leibale @codecov-commenter @GnaneshKunal